[9.4] [Osquery] FF Enabled for Osquery 9.4 rework#258935
Merged
tomsonpl merged 27 commits intoelastic:9.4from Apr 11, 2026
Merged
[9.4] [Osquery] FF Enabled for Osquery 9.4 rework#258935tomsonpl merged 27 commits intoelastic:9.4from
tomsonpl merged 27 commits intoelastic:9.4from
Conversation
…nified data table
…osquery-rule-play
The unified history table's mapLiveHitToRow mapper was not populating replay parameters (savedQueryId, timeout, ecsMapping, agentIds, agentAll, agentPlatforms, agentPolicyIds) from the raw ES hit data. This caused the "Run query" button in the history table to create a new query without the original saved query reference, timeout, agent selection, or ECS mappings.
# Conflicts: # x-pack/platform/plugins/shared/osquery/server/routes/unified_history/map_live_hit_to_row.ts
szwarckonrad
added
release_note:skip
Contributor
|
/ci |
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🟢 Low
The test calls checkActionItemsInResults with lens: true, discover: true, and timeline: false, but the function was refactored to only destructure and validate cases. The assertions for lens, discover, and timeline are silently skipped, so the test passes regardless of whether those UI elements are correctly shown or hidden.
Consider either restoring the parameter assertions in checkActionItemsInResults, or updating the test to remove the unused parameters if validating those action items is no longer required.
Suggested change
| checkActionItemsInResults({ | |
| cases: true, | |
| }); |
🤖 Copy this AI Prompt to have your agent fix this:
In file x-pack/platform/plugins/shared/osquery/cypress/e2e/roles/t1_and_t2_analyst.cy.ts around lines 68-73:
The test calls `checkActionItemsInResults` with `lens: true`, `discover: true`, and `timeline: false`, but the function was refactored to only destructure and validate `cases`. The assertions for `lens`, `discover`, and `timeline` are silently skipped, so the test passes regardless of whether those UI elements are correctly shown or hidden.
Consider either restoring the parameter assertions in `checkActionItemsInResults`, or updating the test to remove the unused parameters if validating those action items is no longer required.
Evidence trail:
x-pack/platform/plugins/shared/osquery/cypress/e2e/roles/t1_and_t2_analyst.cy.ts lines 68-73 (test calling checkActionItemsInResults with lens, discover, cases, timeline parameters); x-pack/platform/plugins/shared/osquery/cypress/tasks/live_query.ts lines 174-185 (function definition showing only `cases` is destructured and used, while discover, lens, timeline are in type signature but ignored)
Contributor
|
/ci |
Contributor
|
/ci |
Contributor
|
/ci |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
|
Contributor
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
szwarckonrad
added
v9.4.0
backport:version
tomsonpl
changed the title
tomsonpl
added a commit
to tomsonpl/kibana
that referenced
this pull request
Apr 13, 2026
…8935) Do not merge. Testing CI and getting ready for GA. --------- Co-authored-by: Tomasz Ciecierski <tomasz.ciecierski@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge.
Testing CI and getting ready for GA.